Socket processing improvements. #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mirasrael
commented
Jan 2, 2024
•
mirasrael
commented
- Add SimpleSocketSender friend class for SimpleSocket for avoiding concurrent state modifications during racing receive and send operations.
- Don't log warning if socket shutdown initiated by client.
- Make StatTimer thread local.
mirasrael
force-pushed
the
ab-fix-simple-socke
branch
from
d200db2 to
2d4d3c5
Compare
1. Add SimpleSocketSender friend class for SimpleSocket for avoiding concurrent state modifications during racing receive and send operations. 2. Don't log warning if socket shutdown initiated by client. 3. Make StatTimer thread local.
mirasrael
force-pushed
the
ab-fix-simple-socke
branch
from
2d4d3c5 to
e43442d
Compare
ForNeVeR
requested changes
Jan 2, 2024
mirasrael
force-pushed
the
ab-fix-simple-socke
branch
from
e66749a to
8ce2b73
Compare
… non-TCP protocol.
…ith logView2 was called after logView2 already destroyed).
mirasrael
force-pushed
the
ab-fix-simple-socke
branch
from
8ce2b73 to
8cdf969
Compare
ForNeVeR
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.